mohammadian7/freqtrade
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't remove elements from list we're iterating over

Browse Source 
closes #9127
This commit is contained in:
Matthias
2023-08-29 17:44:39 +02:00
parent 5efa40215b
commit 5eb446f1ce
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
freqtrade/plugins/pairlist/pairlist_helpers.py
+2 -3
View File
@@ -29,9 +29,8 @@ def expand_pairlist(wildcardpl: List[str], available_pairs: List[str],
except re.error as err: except re.error as err:
raise ValueError(f"Wildcard error in {pair_wc}, {err}") raise ValueError(f"Wildcard error in {pair_wc}, {err}")
for element in result: result = [element for element in result if re.fullmatch(r'^[A-Za-z0-9:/-]+$', element)]
if not re.fullmatch(r'^[A-Za-z0-9:/-]+$', element):
result.remove(element)
else: else:
for pair_wc in wildcardpl: for pair_wc in wildcardpl:
try: try:
tests/plugins/test_pairlist.py
+3
View File
@@ -1373,6 +1373,9 @@ def test_expand_pairlist(wildcardlist, pairs, expected):
(['BTC/USDT:USDT'], (['BTC/USDT:USDT'],
['BTC/USDT:USDT', 'BTC/USDT'], ['BTC/USDT:USDT', 'BTC/USDT'],
['BTC/USDT:USDT']), ['BTC/USDT:USDT']),
(['BB_BTC/USDT', 'CC_BTC/USDT', 'AA_ETH/USDT', 'XRP/USDT', 'ETH/USDT', 'XX_BTC/USDT'],
['BTC/USDT', 'ETH/USDT'],
['XRP/USDT', 'ETH/USDT']),
]) ])
def test_expand_pairlist_keep_invalid(wildcardlist, pairs, expected): def test_expand_pairlist_keep_invalid(wildcardlist, pairs, expected):
if expected is None: if expected is None: