diff --git a/freqtrade/data/history/featherdatahandler.py b/freqtrade/data/history/featherdatahandler.py index 70d36628d..b8efe6d02 100644 --- a/freqtrade/data/history/featherdatahandler.py +++ b/freqtrade/data/history/featherdatahandler.py @@ -95,11 +95,11 @@ class FeatherDataHandler(IDataHandler): tradesdata = DataFrame(data, columns=DEFAULT_TRADES_COLUMNS) tradesdata.to_feather(filename, compression_level=9, compression='lz4') - def trades_append(self, pair: str, data: TradeList): + def trades_append(self, pair: str, data: DataFrame): """ Append data to existing files :param pair: Pair - used for filename - :param data: List of Lists containing trade data, + :param data: Dataframe containing trades column sequence as in DEFAULT_TRADES_COLUMNS """ raise NotImplementedError() diff --git a/freqtrade/data/history/hdf5datahandler.py b/freqtrade/data/history/hdf5datahandler.py index c9e546eab..38747ed5f 100644 --- a/freqtrade/data/history/hdf5datahandler.py +++ b/freqtrade/data/history/hdf5datahandler.py @@ -115,11 +115,11 @@ class HDF5DataHandler(IDataHandler): format='table', data_columns=['timestamp'] ) - def trades_append(self, pair: str, data: TradeList): + def trades_append(self, pair: str, data: pd.DataFrame): """ Append data to existing files :param pair: Pair - used for filename - :param data: List of Lists containing trade data, + :param data: Dataframe containing trades column sequence as in DEFAULT_TRADES_COLUMNS """ raise NotImplementedError() diff --git a/freqtrade/data/history/idatahandler.py b/freqtrade/data/history/idatahandler.py index a11c79bd9..fe2bb1427 100644 --- a/freqtrade/data/history/idatahandler.py +++ b/freqtrade/data/history/idatahandler.py @@ -180,11 +180,11 @@ class IDataHandler(ABC): """ @abstractmethod - def trades_append(self, pair: str, data: TradeList): + def trades_append(self, pair: str, data: DataFrame): """ Append data to existing files :param pair: Pair - used for filename - :param data: List of Lists containing trade data, + :param data: Dataframe containing trades column sequence as in DEFAULT_TRADES_COLUMNS """ diff --git a/freqtrade/data/history/jsondatahandler.py b/freqtrade/data/history/jsondatahandler.py index cd40da316..4e0a5dc1a 100644 --- a/freqtrade/data/history/jsondatahandler.py +++ b/freqtrade/data/history/jsondatahandler.py @@ -104,11 +104,11 @@ class JsonDataHandler(IDataHandler): filename = self._pair_trades_filename(self._datadir, pair) misc.file_dump_json(filename, data, is_zip=self._use_zip) - def trades_append(self, pair: str, data: TradeList): + def trades_append(self, pair: str, data: DataFrame): """ Append data to existing files :param pair: Pair - used for filename - :param data: List of Lists containing trade data, + :param data: Dataframe containing trades column sequence as in DEFAULT_TRADES_COLUMNS """ raise NotImplementedError() diff --git a/freqtrade/data/history/parquetdatahandler.py b/freqtrade/data/history/parquetdatahandler.py index e6b2481d2..085ff8be6 100644 --- a/freqtrade/data/history/parquetdatahandler.py +++ b/freqtrade/data/history/parquetdatahandler.py @@ -95,11 +95,11 @@ class ParquetDataHandler(IDataHandler): # array # feather.write_feather(data, filename) - def trades_append(self, pair: str, data: TradeList): + def trades_append(self, pair: str, data: DataFrame): """ Append data to existing files :param pair: Pair - used for filename - :param data: List of Lists containing trade data, + :param data: Dataframe containing trades column sequence as in DEFAULT_TRADES_COLUMNS """ raise NotImplementedError() diff --git a/tests/data/test_datahandler.py b/tests/data/test_datahandler.py index 36e69f4f8..b0c2149d4 100644 --- a/tests/data/test_datahandler.py +++ b/tests/data/test_datahandler.py @@ -291,7 +291,7 @@ def test_datahandler_ohlcv_append(datahandler, testdatadir, ): def test_datahandler_trades_append(datahandler, testdatadir): dh = get_datahandler(testdatadir, datahandler) with pytest.raises(NotImplementedError): - dh.trades_append('UNITTEST/ETH', []) + dh.trades_append('UNITTEST/ETH', DataFrame()) def test_hdf5datahandler_trades_get_pairs(testdatadir):