mohammadian7/freqtrade
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Invert parameters for initialize_single_lookahead_analysis

Browse Source 
otherwise their order is reversed before calling LookaheadAnalysis for no good reason
This commit is contained in:
Matthias
2023-06-15 20:42:26 +02:00
parent ad74e65673
commit 964bf76469
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
freqtrade/optimize/lookahead_analysis_helpers.py
+2 -2
View File
@@ -150,7 +150,7 @@ class LookaheadAnalysisSubFunctions:
return config return config
@staticmethod @staticmethod
def initialize_single_lookahead_analysis(strategy_obj: Dict[str, Any], config: Dict[str, Any]): def initialize_single_lookahead_analysis(config: Config, strategy_obj: Dict[str, Any]):
logger.info(f"Bias test of {Path(strategy_obj['location']).name} started.") logger.info(f"Bias test of {Path(strategy_obj['location']).name} started.")
start = time.perf_counter() start = time.perf_counter()
@@ -186,7 +186,7 @@ class LookaheadAnalysisSubFunctions:
if strategy_obj['name'] == strat and strategy_obj not in strategy_list: if strategy_obj['name'] == strat and strategy_obj not in strategy_list:
lookaheadAnalysis_instances.append( lookaheadAnalysis_instances.append(
LookaheadAnalysisSubFunctions.initialize_single_lookahead_analysis( LookaheadAnalysisSubFunctions.initialize_single_lookahead_analysis(
strategy_obj, config)) config, strategy_obj))
break break
# report the results # report the results
tests/optimize/test_lookahead_analysis.py
+11 -3
View File
@@ -291,7 +291,7 @@ def test_lookahead_helper_export_to_csv(lookahead_conf):
Path(lookahead_conf['lookahead_analysis_exportfilename']).unlink() Path(lookahead_conf['lookahead_analysis_exportfilename']).unlink()
def test_initialize_single_lookahead_analysis(lookahead_conf, mocker): def test_initialize_single_lookahead_analysis(lookahead_conf, mocker, caplog):
mocker.patch('freqtrade.data.history.get_timerange', get_timerange) mocker.patch('freqtrade.data.history.get_timerange', get_timerange)
mocker.patch(f'{EXMS}.get_fee', return_value=0.0) mocker.patch(f'{EXMS}.get_fee', return_value=0.0)
mocker.patch(f'{EXMS}.get_min_pair_stake_amount', return_value=0.00001) mocker.patch(f'{EXMS}.get_min_pair_stake_amount', return_value=0.00001)
@@ -303,9 +303,17 @@ def test_initialize_single_lookahead_analysis(lookahead_conf, mocker):
lookahead_conf['timeframe'] = '5m' lookahead_conf['timeframe'] = '5m'
lookahead_conf['timerange'] = '20180119-20180122' lookahead_conf['timerange'] = '20180119-20180122'
strategy_obj = {'name': "strategy_test_v3_with_lookahead_bias"} start_mock = mocker.patch('freqtrade.optimize.lookahead_analysis.LookaheadAnalysis.start')
strategy_obj = {
'name': "strategy_test_v3_with_lookahead_bias",
'location': Path(lookahead_conf['strategy_path'], f"{lookahead_conf['strategy']}.py")
}
instance = LookaheadAnalysisSubFunctions.initialize_single_lookahead_analysis(
lookahead_conf, strategy_obj)
assert log_has_re(r"Bias test of .* started\.", caplog)
assert start_mock.call_count == 1
instance = LookaheadAnalysis(lookahead_conf, strategy_obj)
assert instance.strategy_obj['name'] == "strategy_test_v3_with_lookahead_bias" assert instance.strategy_obj['name'] == "strategy_test_v3_with_lookahead_bias"