Simplify api backtesting by extracting the background_method

freqtrade/rpc/api_server/api_backtest.py

@@ -8,6 +8,7 @@ from fastapi import APIRouter, BackgroundTasks, Depends
 from fastapi.exceptions import HTTPException
 
 from freqtrade.configuration.config_validation import validate_config_consistency
+from freqtrade.constants import Config
 from freqtrade.data.btanalysis import get_backtest_resultlist, load_and_merge_backtest_result
 from freqtrade.enums import BacktestState
 from freqtrade.exceptions import DependencyException, OperationalException
@@ -26,39 +27,8 @@ logger = logging.getLogger(__name__)
 router = APIRouter()
 
 
-@router.post('/backtest', response_model=BacktestResponse, tags=['webserver', 'backtest'])
-async def api_start_backtest(  # noqa: C901
-        bt_settings: BacktestRequest, background_tasks: BackgroundTasks,
-        config=Depends(get_config), ws_mode=Depends(is_webserver_mode)):
-    ApiBG.bt['bt_error'] = None
-    """Start backtesting if not done so already"""
-    if ApiBG.bgtask_running:
-        raise RPCException('Bot Background task already running')
-
-    if ':' in bt_settings.strategy:
-        raise HTTPException(status_code=500, detail="base64 encoded strategies are not allowed.")
-
-    btconfig = deepcopy(config)
-    remove_exchange_credentials(btconfig['exchange'], True)
-    settings = dict(bt_settings)
-    if settings.get('freqai', None) is not None:
-        settings['freqai'] = dict(settings['freqai'])
-    # Pydantic models will contain all keys, but non-provided ones are None
-
-    btconfig = deep_merge_dicts(settings, btconfig, allow_null_overrides=False)
-    try:
-        btconfig['stake_amount'] = float(btconfig['stake_amount'])
-    except ValueError:
-        pass
-
-    # Force dry-run for backtesting
-    btconfig['dry_run'] = True
-
-    # Start backtesting
-    # Initialize backtesting object
-    def run_backtest():
-        from freqtrade.optimize.optimize_reports import (generate_backtest_stats,
-                                                         store_backtest_stats)
+def __run_backtest_bg(btconfig: Config):
+    from freqtrade.optimize.optimize_reports import generate_backtest_stats, store_backtest_stats
     from freqtrade.resolvers import StrategyResolver
     asyncio.set_event_loop(asyncio.new_event_loop())
     try:
@@ -128,7 +98,39 @@ async def api_start_backtest(  # noqa: C901
     finally:
         ApiBG.bgtask_running = False
 
-    background_tasks.add_task(run_backtest)
+
+@router.post('/backtest', response_model=BacktestResponse, tags=['webserver', 'backtest'])
+async def api_start_backtest(
+        bt_settings: BacktestRequest, background_tasks: BackgroundTasks,
+        config=Depends(get_config), ws_mode=Depends(is_webserver_mode)):
+    ApiBG.bt['bt_error'] = None
+    """Start backtesting if not done so already"""
+    if ApiBG.bgtask_running:
+        raise RPCException('Bot Background task already running')
+
+    if ':' in bt_settings.strategy:
+        raise HTTPException(status_code=500, detail="base64 encoded strategies are not allowed.")
+
+    btconfig = deepcopy(config)
+    remove_exchange_credentials(btconfig['exchange'], True)
+    settings = dict(bt_settings)
+    if settings.get('freqai', None) is not None:
+        settings['freqai'] = dict(settings['freqai'])
+    # Pydantic models will contain all keys, but non-provided ones are None
+
+    btconfig = deep_merge_dicts(settings, btconfig, allow_null_overrides=False)
+    try:
+        btconfig['stake_amount'] = float(btconfig['stake_amount'])
+    except ValueError:
+        pass
+
+    # Force dry-run for backtesting
+    btconfig['dry_run'] = True
+
+    # Start backtesting
+    # Initialize backtesting object
+
+    background_tasks.add_task(__run_backtest_bg, btconfig=btconfig)
     ApiBG.bgtask_running = True
 
     return {