From d898c80e65761e1338491681ede0674a5cd04c96 Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Sun, 8 Dec 2024 16:40:56 +0100
Subject: [PATCH] test: Add test for get_conversion_rate

---
 freqtrade/exchange/exchange.py  |  6 ++++-
 tests/exchange/test_exchange.py | 43 +++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/freqtrade/exchange/exchange.py b/freqtrade/exchange/exchange.py
index a0343147c..875cff6ee 100644
--- a/freqtrade/exchange/exchange.py
+++ b/freqtrade/exchange/exchange.py
@@ -1867,7 +1867,11 @@ class Exchange:
         if coin == currency:
             return 1.0
         tickers = self.get_tickers(cached=True)
-        pair = self.get_valid_pair_combination(coin, currency)
+        try:
+            pair = self.get_valid_pair_combination(coin, currency)
+        except ValueError:
+            return None
+
         ticker: Ticker | None = tickers.get(pair, None)
         if not ticker:
             tickers_other: Tickers = self.get_tickers(
diff --git a/tests/exchange/test_exchange.py b/tests/exchange/test_exchange.py
index af95e5748..085982d1d 100644
--- a/tests/exchange/test_exchange.py
+++ b/tests/exchange/test_exchange.py
@@ -2006,6 +2006,49 @@ def test_get_tickers(default_conf, mocker, exchange_name, caplog):
     assert exchange.get_tickers() == {}
 
 
+@pytest.mark.parametrize("exchange_name", EXCHANGES)
+def test_get_conversion_rate(default_conf_usdt, mocker, exchange_name):
+    api_mock = MagicMock()
+    tick = {
+        "ETH/USDT": {
+            "last": 42,
+        },
+        "BCH/USDT": {
+            "last": 41,
+        },
+        "ETH/BTC": {
+            "last": 250,
+        },
+    }
+    tick2 = {
+        "XRP/USDT": {
+            "symbol": "XRP/USDT",
+            "bid": 0.5,
+            "ask": 1,
+            "last": 2.5,
+        }
+    }
+    mocker.patch(f"{EXMS}.exchange_has", return_value=True)
+    api_mock.fetch_tickers = MagicMock(side_effect=[tick, tick2])
+    api_mock.fetch_bids_asks = MagicMock(return_value={})
+
+    exchange = get_patched_exchange(mocker, default_conf_usdt, api_mock, exchange=exchange_name)
+    # retrieve original ticker
+    assert exchange.get_conversion_rate("USDT", "USDT") == 1
+    assert api_mock.fetch_tickers.call_count == 0
+    assert exchange.get_conversion_rate("ETH", "USDT") == 42
+    assert exchange.get_conversion_rate("ETH", "USDC") is None
+    assert exchange.get_conversion_rate("ETH", "BTC") == 250
+    assert exchange.get_conversion_rate("BTC", "ETH") == 0.004
+
+    assert api_mock.fetch_tickers.call_count == 1
+    api_mock.fetch_tickers.reset_mock()
+
+    assert exchange.get_conversion_rate("XRP", "USDT") == 2.5
+    # Only the call to the "others" market
+    assert api_mock.fetch_tickers.call_count == 1
+
+
 @pytest.mark.parametrize("exchange_name", EXCHANGES)
 def test_fetch_ticker(default_conf, mocker, exchange_name):
     api_mock = MagicMock()